3x-ui-agent/internal/config/config_test.go

package config

import (
	"os"
	"testing"
)

func TestGetPanelVersion(t *testing.T) {
	orig := buildCommit
	t.Cleanup(func() { buildCommit = orig })

	buildCommit = ""
	if got := GetPanelVersion(); got != GetBaseVersion() {
		t.Fatalf("stable build: GetPanelVersion = %q, want %q", got, GetBaseVersion())
	}

	buildCommit = "1d1128cf"
	if got := GetPanelVersion(); got != "dev+1d1128cf" {
		t.Fatalf("dev build: GetPanelVersion = %q, want %q", got, "dev+1d1128cf")
	}

	buildCommit = "1d1128cf945c4615efa05cf41ba7fa766e2ee428"
	if got := GetPanelVersion(); got != "dev+1d1128cf" {
		t.Fatalf("dev build (full sha): GetPanelVersion = %q, want %q", got, "dev+1d1128cf")
	}
}

func TestGetBaseVersionBuildVersionOverride(t *testing.T) {
	orig := buildVersion
	t.Cleanup(func() { buildVersion = orig })

	// No injection (plain `go build`): the embedded version file wins.
	buildVersion = ""
	embedded := GetBaseVersion()
	if embedded == "" {
		t.Fatal("embedded version file must not be empty")
	}

	// Injected fork release version wins over the embedded file and flows
	// into GetPanelVersion untouched (stable channel, no dev label).
	buildVersion = "3.7.0-agent.1"
	if got := GetBaseVersion(); got != "3.7.0-agent.1" {
		t.Fatalf("injected build: GetBaseVersion = %q, want %q", got, "3.7.0-agent.1")
	}
	if got := GetPanelVersion(); got != "3.7.0-agent.1" {
		t.Fatalf("injected build: GetPanelVersion = %q, want %q", got, "3.7.0-agent.1")
	}

	// Whitespace-only injection counts as unset.
	buildVersion = "  "
	if got := GetBaseVersion(); got != embedded {
		t.Fatalf("blank injection: GetBaseVersion = %q, want embedded %q", got, embedded)
	}
}

func TestDisplayVersionDefaultsAndOverride(t *testing.T) {
	orig := displayVersion
	t.Cleanup(func() { displayVersion = orig })

	displayVersion = ""
	if got := GetDisplayVersion(); got != "1.0.0" {
		t.Fatalf("default display version = %q, want 1.0.0", got)
	}
	if got := GetMasterDisplayVersion(); got != "V1.0.0" {
		t.Fatalf("default master display version = %q, want V1.0.0", got)
	}
	if got := GetAgentDisplayVersion(); got != "A1.0.0" {
		t.Fatalf("default agent display version = %q, want A1.0.0", got)
	}

	displayVersion = "1.0.1"
	if got := GetMasterDisplayVersion(); got != "V1.0.1" {
		t.Fatalf("injected master display version = %q, want V1.0.1", got)
	}
	if got := GetAgentDisplayVersion(); got != "A1.0.1" {
		t.Fatalf("injected agent display version = %q, want A1.0.1", got)
	}
}

func TestParseDisplayVersion(t *testing.T) {
	valid := map[string][3]int{
		"1.0.0":   {1, 0, 0},
		"V1.0.0":  {1, 0, 0},
		"A1.0.9":  {1, 0, 9},
		"v2.0.0":  {2, 0, 0},
		" 1.2.3 ": {1, 2, 3},
	}
	for in, want := range valid {
		got, ok := ParseDisplayVersion(in)
		if !ok || got != want {
			t.Fatalf("ParseDisplayVersion(%q) = %v, %v; want %v, true", in, got, ok, want)
		}
	}
	invalid := []string{"", "3.7.0-agent.1", "dev+1a2b3c4d", "1.0", "1.0.0.1", "1.x.0", "V", "1..0"}
	for _, in := range invalid {
		if _, ok := ParseDisplayVersion(in); ok {
			t.Fatalf("ParseDisplayVersion(%q) ok=true, want false", in)
		}
	}
}

func TestCompareDisplayVersion(t *testing.T) {
	cases := []struct {
		a, b string
		want int
	}{
		{"1.0.0", "1.0.0", 0},
		{"V1.0.0", "A1.0.0", 0},  // prefix letters are flavour, not value
		{"1.0.9", "1.1.0", -1},   // single-digit carry step
		{"1.1.0", "1.0.9", 1},    // carry compares numerically, not lexically
		{"1.9.9", "2.0.0", -1},   // full carry
		{"A1.0.1", "A1.0.0", 1},  // agent series
		{"V1.0.1", "1.0.0", 1},   // release tag vs current
		{"2.0.0", "1.9.9", 1},
		{"1.0.0", "1.0.1", -1},
	}
	for _, tc := range cases {
		got, ok := CompareDisplayVersion(tc.a, tc.b)
		if !ok || got != tc.want {
			t.Fatalf("CompareDisplayVersion(%q, %q) = %d, %v; want %d, true", tc.a, tc.b, got, ok, tc.want)
		}
	}
	if _, ok := CompareDisplayVersion("3.7.0-agent.1", "1.0.0"); ok {
		t.Fatal("unparseable side must report ok=false")
	}
}

func TestGetPortOverride(t *testing.T) {
	tests := []struct {
		name       string
		value      string
		set        bool
		wantPort   int
		configured bool
		wantErr    bool
	}{
		{name: "unset"},
		{name: "empty", value: "", set: true},
		{name: "whitespace", value: "   ", set: true},
		{name: "minimum", value: "1", set: true, wantPort: 1, configured: true},
		{name: "default panel port", value: "2053", set: true, wantPort: 2053, configured: true},
		{name: "surrounding whitespace", value: " 8080 ", set: true, wantPort: 8080, configured: true},
		{name: "maximum", value: "65535", set: true, wantPort: 65535, configured: true},
		{name: "zero", value: "0", set: true, configured: true, wantErr: true},
		{name: "above maximum", value: "65536", set: true, configured: true, wantErr: true},
		{name: "negative", value: "-1", set: true, configured: true, wantErr: true},
		{name: "non-numeric", value: "abc", set: true, configured: true, wantErr: true},
		{name: "decimal", value: "8080.0", set: true, configured: true, wantErr: true},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			if tt.set {
				t.Setenv("XUI_PORT", tt.value)
			} else {
				original, existed := os.LookupEnv("XUI_PORT")
				if err := os.Unsetenv("XUI_PORT"); err != nil {
					t.Fatalf("unset XUI_PORT: %v", err)
				}
				t.Cleanup(func() {
					if existed {
						_ = os.Setenv("XUI_PORT", original)
					} else {
						_ = os.Unsetenv("XUI_PORT")
					}
				})
			}

			port, configured, err := GetPortOverride()
			if port != tt.wantPort {
				t.Errorf("port = %d, want %d", port, tt.wantPort)
			}
			if configured != tt.configured {
				t.Errorf("configured = %t, want %t", configured, tt.configured)
			}
			if (err != nil) != tt.wantErr {
				t.Errorf("error = %v, wantErr %t", err, tt.wantErr)
			}
		})
	}
}